Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs horizontal scrollbar #24878

Merged
merged 5 commits into from
Nov 27, 2017
Merged

Fix docs horizontal scrollbar #24878

merged 5 commits into from
Nov 27, 2017

Commits on Nov 26, 2017

  1. Configuration menu
    Copy the full SHA
    bc47d3c View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2017

  1. Configuration menu
    Copy the full SHA
    c848d42 View commit details
    Browse the repository at this point in the history
  2. Drop the handleUpdate() variant

    While I understand the variant covers the "get a particular plugin instance" case from http://getbootstrap.com/docs/4.0/getting-started/javascript/#programmatic-api it seems weird that we do it here but not everywhere else in the docs (randomly checking other pages, we seem to stick to the documented methods as written on those pages). As this isn't properly explained as is, and as it adds nothing (more of a preference for authors), it would be easier to just drop the variant and stick with the documented method as outlined later on in the same page (avoids having to go off on a "why should you use this instead of that" tangent here).
    patrickhlauke committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    e07f99e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    72083aa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f1d08a8 View commit details
    Browse the repository at this point in the history