Restore .table-responsive as a parent class #25058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
20 tasks
pi0
pushed a commit
to bootstrap-vue/bootstrap-vue
that referenced
this pull request
Jan 23, 2018
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the original behavior of
.table-responsiveas a parent class, removing the ability to use it as a modifier class. This was primarily done to address a11y issues stemming from changing thedisplayof a<table>—it interferes with screenreaders' ability to announce a table.As a result, responsive tables will no longer be shrunk to their contents. This fixes #24638 (latest issue), fixes #24256, fixes #24462, fixes #24464. Something tells me y'all never liked that anyway though. 😬
I've tweaked a bit of the docs around this as well, adding a line here and there while also cleaning up the examples a smidge.