Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add broken-link-checker. #26741

Merged
merged 2 commits into from
Jun 25, 2018
Merged

Add broken-link-checker. #26741

merged 2 commits into from
Jun 25, 2018

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Jun 21, 2018

Fixes #18568.

Things to consider:

  • [ ] IMHO we should check the external links too. It will be slower but it's the only way we can check more things - Postponed for later
  • Where should the task be placed? Only on Travis? In npm test?

@XhmikosR XhmikosR force-pushed the v4-dev-xmr-broken-link-checker branch 2 times, most recently from b8b91f9 to e0f4f9a Compare June 23, 2018 22:36
@XhmikosR
Copy link
Member Author

BTW, if anyone knows an alternative to blc package let me know.

@XhmikosR XhmikosR force-pushed the v4-dev-xmr-broken-link-checker branch from e0f4f9a to 81f3b39 Compare June 25, 2018 04:33
Copy link
Member

@Johann-S Johann-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @XhmikosR 👍

I like the add of http-server 😲

I'm more in favor to run that task in Travis

@XhmikosR XhmikosR force-pushed the v4-dev-xmr-broken-link-checker branch from 81f3b39 to d458096 Compare June 25, 2018 11:54
@XhmikosR XhmikosR force-pushed the v4-dev-xmr-broken-link-checker branch from d458096 to c3a77d5 Compare June 25, 2018 12:02
@mdo mdo mentioned this pull request Jun 25, 2018
@XhmikosR XhmikosR merged commit 4112df4 into v4-dev Jun 25, 2018
@XhmikosR XhmikosR deleted the v4-dev-xmr-broken-link-checker branch June 25, 2018 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants