Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use utility API for all utilities & intruduce link-* helpers #29267

Merged
merged 2 commits into from
Aug 26, 2019

Conversation

MartijnCuppens
Copy link
Member

Add all remaining utilities to the utility API. I needed to tweak the mixin a bit to make it work for the visibility mixins.

I've also dropped the :hover and :focus states of a.text-* color utilities and instead added new .link-* helper classes. This way there's a stricter distinction between helpers and utilities: helpers handle more than one property and utilities only take care of one single property without hover or focus states.

@MartijnCuppens MartijnCuppens marked this pull request as ready for review August 17, 2019 19:59
@MartijnCuppens MartijnCuppens requested a review from a team as a code owner August 17, 2019 19:59
@MartijnCuppens MartijnCuppens merged commit 19ee63a into master Aug 26, 2019
@MartijnCuppens MartijnCuppens deleted the master-mc-link-helpers branch August 26, 2019 06:21
crhistianramirez pushed a commit to crhistianramirez/headstart that referenced this pull request Dec 28, 2022
.text-* utilities do not add hover and focus states to links anymore. .link-* helper classes can be used instead. See twbs/bootstrap#29267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants