Add maps for all colors, document how to extend color utilities #32319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
reviewed
Dec 4, 2020
- Moves color maps into _variables.scss for now (felt weird to split them out when the variables are there) - Adds a new function, map-merge-multiple(), and updates docs that reference combo-map - Updates code snippet and docs guidance about how to extend the color utils to handle this
ffoodd
approved these changes
Jun 29, 2021
marvin-hinkley-vortx
pushed a commit
to Vortx-Inc/bootstrap
that referenced
this pull request
Aug 18, 2021
…#32319) * Add maps for all colors, document how to extend color utilities * Updates to make this more functional for v5 - Moves color maps into _variables.scss for now (felt weird to split them out when the variables are there) - Adds a new function, map-merge-multiple(), and updates docs that reference combo-map - Updates code snippet and docs guidance about how to extend the color utils to handle this * Update site/content/docs/5.0/customize/color.md Co-authored-by: Gaël Poupard <ffoodd@users.noreply.github.com> Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to give folks the tools they need to extend our full color palette into any number of utilities, from
colortobackground-colorand beyond. I've added the maps to the_variables.scssfile as our existing color variables all live there right now. I've also added some docs guidance for how to put it to use to the Customize > Color page. This also includes adding a newmap-merge-multiple()function for combining several Sass maps, since otherwise we'd need to do nested maps for each merge./cc @twbs/css-review
Closes #32236, closes #33412.
Preview: https://deploy-preview-32319--twbs-bootstrap.netlify.app/docs/5.0/customize/color/#generating-utilities