Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix event handler removal in dropdown/carousel dispose #33000

Merged
merged 8 commits into from
Feb 12, 2021
Merged

Fix event handler removal in dropdown/carousel dispose #33000

merged 8 commits into from
Feb 12, 2021

Conversation

kyletsang
Copy link
Contributor

Fixes #32983

@kyletsang kyletsang requested a review from a team as a code owner February 6, 2021 08:21
@rohit2sharma95
Copy link
Collaborator

Thanks for the PR @kyletsang
This should be done for all the components. Can you please update the remaining components as well? 🙂

@kyletsang kyletsang marked this pull request as draft February 6, 2021 17:52
@kyletsang kyletsang marked this pull request as ready for review February 6, 2021 20:11
@kyletsang kyletsang changed the title Fix event handler removal in dropdown dispose Fix event handler removal in dropdown/carousel dispose Feb 6, 2021
@kyletsang
Copy link
Contributor Author

Good to go @rohit2sharma95.

The only other component that needed fixing was Carousel. I've also modded the other unit tests to specifically spy on the add/remove event listener functions.

@kyletsang kyletsang force-pushed the fix/dropdown-dispose branch from a8999b4 to a6b32f6 Compare February 8, 2021 20:14
@kyletsang kyletsang force-pushed the fix/dropdown-dispose branch from a6b32f6 to 2166472 Compare February 8, 2021 20:19
@kyletsang
Copy link
Contributor Author

@XhmikosR, good to go here. I've rebased and cleaned up my commits.

@XhmikosR XhmikosR mentioned this pull request Feb 11, 2021
Closed
@XhmikosR
Copy link
Member

@rohit2sharma95 LGTY? I think it's good to go AFAICT

@XhmikosR XhmikosR merged commit 02dbd87 into twbs:main Feb 12, 2021
@XhmikosR
Copy link
Member

@kyletsang it seems tests break on Mobile Safari 10.0 (iOS 10.3.2) https://github.com/twbs/bootstrap/runs/1885114564

Could you please have a look?

@kyletsang kyletsang deleted the fix/dropdown-dispose branch February 12, 2021 06:18
@rohit2sharma95 rohit2sharma95 mentioned this pull request Feb 12, 2021
Merged
This was referenced Jul 12, 2024
Open
Open
Open
Open
Open
This was referenced Jul 27, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhlauke patrickhlauke patrickhlauke left review comments

@XhmikosR XhmikosR XhmikosR left review comments

@rohit2sharma95 rohit2sharma95 rohit2sharma95 approved these changes

Assignees
No one assigned
Labels
js v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dropdown.dispose() does not remove event listeners
4 participants
@kyletsang @rohit2sharma95 @XhmikosR @patrickhlauke