Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sibling card links in RTL #33154

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Fix sibling card links in RTL #33154

merged 2 commits into from
Feb 22, 2021

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Feb 19, 2021

@ffoodd ffoodd requested a review from a team as a code owner February 19, 2021 12:44
@ffoodd ffoodd changed the title fix(card): siblings card links in RTL Siblings card links in RTL Feb 19, 2021
@ffoodd ffoodd mentioned this pull request Feb 19, 2021
20 tasks
@XhmikosR XhmikosR changed the title Siblings card links in RTL Fix sibling card links in RTL Feb 19, 2021
@aqeelat
Copy link
Contributor

aqeelat commented Feb 19, 2021

A better solution is to add /* rtl:options:{} */ in a line before 72. This way, it replaces the word "left" with "right" in the css.
#33155

margin-inline-start would also work, but I think @XhmikosR does not recommend it.

@ffoodd
Copy link
Member Author

ffoodd commented Feb 19, 2021

@aqeelat This is useless, RTLCSS does convert left to right as a default: we only have to not ignoring the rule.

And logical properties aren't supported enough to introduce them yet. It'll be a v6 step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants