Popover & Tooltip: Allow dispose/hide methods usage through jQueryIntreface
#33371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
changed the title
GeoSot
force-pushed
the
gs-streamline-jq-inreface-on-tooltip-popover
branch
from
332657a to
0983bdf
Compare
GeoSot
force-pushed
the
gs-streamline-jq-inreface-on-tooltip-popover
branch
from
0983bdf to
7097979
Compare
GeoSot
force-pushed
the
gs-streamline-jq-inreface-on-tooltip-popover
branch
from
7097979 to
fdffca7
Compare
GeoSot
changed the title
GeoSot
force-pushed
the
gs-streamline-jq-inreface-on-tooltip-popover
branch
from
fdffca7 to
587ccef
Compare
|
Is this a breaking change maybe? Because popovers and tooltips would dispatch events now when hidden through jQuery (without being initialized before)? |
|
I guess yes, but only if a developer initializes its code like : |
GeoSot
force-pushed
the
gs-streamline-jq-inreface-on-tooltip-popover
branch
from
587ccef to
151524a
Compare
alpadev
approved these changes
May 19, 2021
|
@XhmikosR @rohit2sharma95 any other considerations on this? |
rohit2sharma95
approved these changes
May 20, 2021
marvin-hinkley-vortx
pushed a commit
to Vortx-Inc/bootstrap
that referenced
this pull request
May 20, 2021
…nterface, when component does not exists. (twbs#33371)
XhmikosR
changed the title
dispose/hide methods usage through jQueryIntreface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the other components, forward called methods through jQueryInterface.
Popover and Tooltip is good to have the same behavior, as it is on the developer hand to decide how to use them, regardless of js/jQuery usage