Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow offcanvas to be initialized in open state #33382

Merged
merged 8 commits into from
Mar 23, 2021
Merged

Allow offcanvas to be initialized in open state #33382

merged 8 commits into from
Mar 23, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Mar 16, 2021 •
edited
Loading

According to this offcanvas should be able to initialized on shown state if it has the show class on its markup .
I am not sure of this. Any Opinions?
(tests will be added after decision is made)

Preview
Closes #33372

@GeoSot GeoSot requested a review from a team as a code owner March 16, 2021 17:27
@iainhallam
Copy link

May be worth noting the current documentation implies that this is possible on line 182:

If you’d like it to default open, add the additional class show.

@GeoSot GeoSot changed the title Allow offcanvas to be initialized open Allow offcanvas to be initialized in open state Mar 16, 2021
@GeoSot GeoSot marked this pull request as draft March 16, 2021 21:51
mdo
mdo approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ayy this looks good to me. I've updated the first example in the docs for this to put it to use. Now makes it much more dynamic inside the example.

@XhmikosR
Copy link
Member

This needs some more work on the JS side for sure and the example blocks page scrolling now until the example is closed :P

@GeoSot GeoSot force-pushed the gs-initialize-offcanvas-with-is_shown-false branch from 71dfb0d to 9f0e7ef Compare March 17, 2021 22:29
@GeoSot GeoSot force-pushed the gs-initialize-offcanvas-with-is_shown-false branch 4 times, most recently from 91ac502 to f6572d0 Compare March 18, 2021 00:22
@GeoSot GeoSot force-pushed the gs-initialize-offcanvas-with-is_shown-false branch from f6572d0 to a817e05 Compare March 18, 2021 00:24
@GeoSot GeoSot marked this pull request as ready for review March 18, 2021 00:27
@GeoSot GeoSot requested a review from a team as a code owner March 18, 2021 00:27
@mdo
Copy link
Member

mdo commented Mar 22, 2021

How we looking here? :)

@GeoSot
Copy link
Member Author

GeoSot commented Mar 22, 2021

seems ok. It was a minor change

@XhmikosR XhmikosR merged commit 1c02ef4 into main Mar 23, 2021
@XhmikosR XhmikosR deleted the gs-initialize-offcanvas-with-is_shown-false branch March 23, 2021 06:23
@rohit2sharma95 rohit2sharma95 mentioned this pull request Mar 28, 2021
Closed
This was referenced Jul 12, 2024
Open
Open
Open
Open
Open
This was referenced Jul 27, 2024
Open
Open
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@XhmikosR XhmikosR XhmikosR approved these changes

@patrickhlauke patrickhlauke Awaiting requested review from patrickhlauke

@rohit2sharma95 rohit2sharma95 Awaiting requested review from rohit2sharma95

Assignees
No one assigned
Labels
js v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v5 Offcanvas: Not visible on page load with show class
4 participants
@GeoSot @iainhallam @XhmikosR @mdo