Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use :read-only css selector instead [readonly] for consistency #33642

Merged
merged 2 commits into from
Apr 17, 2021
+5 −5
Merged

use :read-only css selector instead [readonly] for consistency #33642

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61d7a86
use `:read-only` css selector instead `[readonly]` for consistency
Apr 15, 2021
c4702fb
Merge branch 'main' into use-read-only-for-comsistency
coharishreddy Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions scss/forms/_form-control.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
&[type="file"] {
overflow: hidden; // prevent pseudo element button overlap

&:not(:disabled):not([readonly]) {
&:not(:disabled):not(:read-only) {
cursor: pointer;
}
}
Expand Down Expand Up @@ -65,7 +65,7 @@
// disabled if the fieldset is disabled. Due to implementation difficulty, we
// don't honor that edge case; we style them as disabled anyway.
&:disabled,
&[readonly] {
&:read-only {
background-color: $input-disabled-bg;
border-color: $input-disabled-border-color;
// iOS fix for unreadable disabled content; see https://github.com/twbs/bootstrap/issues/11655.
Expand All @@ -88,7 +88,7 @@
@include transition($btn-transition);
}

&:hover:not(:disabled):not([readonly])::file-selector-button {
&:hover:not(:disabled):not(:read-only)::file-selector-button {
background-color: $form-file-button-hover-bg;
}

Expand All @@ -107,7 +107,7 @@
@include transition($btn-transition);
}

&:hover:not(:disabled):not([readonly])::-webkit-file-upload-button {
&:hover:not(:disabled):not(:read-only)::-webkit-file-upload-button {
background-color: $form-file-button-hover-bg;
}
}
Expand Down Expand Up @@ -203,7 +203,7 @@ textarea {
height: auto; // Override fixed browser height
padding: $input-padding-y;

&:not(:disabled):not([readonly]) {
&:not(:disabled):not(:read-only) {
cursor: pointer;
}

Expand Down