Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown: support .dropdown-item wrapped in <li> tags #33649

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Dropdown: support .dropdown-item wrapped in <li> tags #33649

merged 2 commits into from
Apr 28, 2021

Conversation

cpsievert
Copy link
Contributor

Backports #33634 into v4

@cpsievert cpsievert requested review from a team as code owners April 15, 2021 15:23
@cpsievert cpsievert changed the base branch from main to v4-dev April 15, 2021 15:24
cpsievert added a commit to rstudio/bslib that referenced this pull request Apr 15, 2021
@cpsievert
Port twbs/bootstrap#33649 into 4.6.0
787a18e
@cpsievert cpsievert mentioned this pull request Apr 15, 2021
Merged
cpsievert added a commit to rstudio/bslib that referenced this pull request Apr 15, 2021
@cpsievert
Support .dropdown-item wrapped in <li> tags (#306)
e09af88 
* Port twbs/bootstrap#33649 into 4.6.0

* bump version
@cpsievert cpsievert mentioned this pull request Apr 15, 2021
Merged
2 tasks
@XhmikosR
Copy link
Member

Let's wait until the main PR has landed and this one's tests pass.

@XhmikosR XhmikosR marked this pull request as draft April 16, 2021 05:50
alpadev
alpadev requested changes Apr 18, 2021
View reviewed changes
js/tests/unit/tab.js Outdated Show resolved Hide resolved
@cpsievert

This comment has been minimized.

Sign in to view
@XhmikosR XhmikosR marked this pull request as ready for review April 21, 2021 05:31
@XhmikosR XhmikosR merged commit 4b5eb3c into twbs:v4-dev Apr 28, 2021
@cpsievert cpsievert deleted the tab-li-dropdown-v4 branch April 28, 2021 13:15
@cpsievert cpsievert mentioned this pull request Sep 30, 2021
Merged
This was referenced May 19, 2022
Open
Open
@RohitM-IN RohitM-IN mentioned this pull request May 19, 2024
Open
@humanbot humanbot mentioned this pull request May 20, 2024
Open
@saurabharch saurabharch mentioned this pull request May 20, 2024
Open
@h-gj h-gj mentioned this pull request May 21, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request May 22, 2024
Open
@TheAutisticTechie TheAutisticTechie mentioned this pull request Sep 20, 2024
Open
@rishisqsh rishisqsh mentioned this pull request Sep 20, 2024
Open
@blakegreendev blakegreendev mentioned this pull request Sep 21, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Sep 21, 2024
Open
@ryanwittmers ryanwittmers mentioned this pull request Sep 21, 2024
Open
@tiff-es tiff-es mentioned this pull request Sep 22, 2024
Open
@blakegreendev blakegreendev mentioned this pull request Sep 22, 2024
Open
@DinGo4DEV DinGo4DEV mentioned this pull request Sep 22, 2024
Open
This was referenced Sep 22, 2024
Open
Open
Open
Open
Open
Open
Open
@RohitM-IN RohitM-IN mentioned this pull request Sep 29, 2024
Open
@imsureshbala imsureshbala mentioned this pull request Sep 29, 2024
Open
This was referenced Sep 30, 2024
Open
Open
Open
Open
This was referenced Oct 4, 2024
Open
Open
@RohitM-IN RohitM-IN mentioned this pull request Oct 4, 2024
Open
@saadi1995 saadi1995 mentioned this pull request Oct 5, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Oct 5, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Oct 30, 2024
Open
@snyk-kevin snyk-kevin mentioned this pull request Nov 3, 2024
Open
@leopard1982 leopard1982 mentioned this pull request Nov 3, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpadev alpadev alpadev approved these changes

Assignees
No one assigned
Labels
js v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpsievert @XhmikosR @alpadev