Scrollbar.js Sanitizations #33665
Closed
Scrollbar.js Sanitizations #33665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
force-pushed
the
gs-scrollbar-sanitations
branch
from
c7ed03a to
8f13c43
Compare
GeoSot
force-pushed
the
gs-scrollbar-sanitations
branch
5 times, most recently
from
c0ce47c to
0d877f5
Compare
GeoSot
force-pushed
the
gs-scrollbar-sanitations
branch
2 times, most recently
from
40f5a33 to
5f077e0
Compare
GeoSot
force-pushed
the
gs-scrollbar-sanitations
branch
from
5f077e0 to
54eb3f9
Compare
* Remove `.modal-open` class as it is already handled by scrollbar.js * _modal.scss make modal `overflowY: auto` by default (was on ``.modal-open`, which is the same) * scrollbar.js: avoid to create data-bs attributes for null values & test * Revisit modal, offcanvas, scrollbar tests * set the base to support different rootElement (than body)
GeoSot
force-pushed
the
gs-scrollbar-sanitations
branch
from
54eb3f9 to
1cc295e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: First Pr #33245 was to just decoupling scrollbar functionality form modal.js , coping the existing code as it was.
This Pr optimizes functionality:
.modal-openclass as it is already handled by scrollbar.jsoverflowY: autoby default (was on ``.modal-open`, which is the same)overflowYvalue as attribute and re-set it properly & test