Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing test for clicking select option in a dropdown #33734

Merged
merged 2 commits into from
Apr 25, 2021

Conversation

alpadev
Copy link
Contributor

@alpadev alpadev commented Apr 23, 2021

@alpadev alpadev requested a review from a team as a code owner April 23, 2021 18:31
@alpadev alpadev force-pushed the add-missing-dropdown-test branch from 8b40ffd to 4dcbaa8 Compare April 23, 2021 18:36
@alpadev alpadev force-pushed the add-missing-dropdown-test branch 2 times, most recently from cae3e51 to e015cf8 Compare April 23, 2021 18:40
@rohit2sharma95
Copy link
Collaborator

I see it is not specific to the dropdown inside the navbar only. 🤔

@alpadev
Copy link
Contributor Author

alpadev commented Apr 23, 2021

It's actually not working as intended because the event doesn't reach the clearMenus method for some reason.

Calling it explicitly now.

@alpadev alpadev force-pushed the add-missing-dropdown-test branch from e015cf8 to b314d6a Compare April 23, 2021 19:34
@alpadev alpadev force-pushed the add-missing-dropdown-test branch from b314d6a to bd24116 Compare April 23, 2021 19:49
@alpadev alpadev changed the title Adds missing test for dropdown in navbar Adds missing test for clicking select option in a dropdown Apr 23, 2021
@XhmikosR XhmikosR changed the title Adds missing test for clicking select option in a dropdown Add missing test for clicking select option in a dropdown Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants