Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular readonly input #33929

Closed
wants to merge 2 commits into from
Closed

Conversation

tkrotoff
Copy link
Contributor

Closes #33925

  • First commit: "Inputs of type="file" and type="color" don't support readonly attribute"

HTML5 spec:

image

Browsers ignore the readonly attribute for input type="file" and input type="color". It's not good to style them as disabled inputs since they are not.

  • Second commit: "Don't style read-only input like all browsers and most UI frameworks"

Actually closes #33925

@tkrotoff tkrotoff requested a review from a team as a code owner May 10, 2021 22:46
@tkrotoff tkrotoff force-pushed the regular-readonly-input branch from 9066c19 to c959cac Compare May 12, 2021 06:57
@mdo
Copy link
Member

mdo commented May 13, 2021

Hey there—the right fix would be to revert the change in the original PR, not remove the readonly part entirely. I've opened #33961 to address that. Thanks though!

@mdo mdo closed this May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readonly inputs shouldn't be grayed out
2 participants