Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor scrollbar.js to be used as a Class #33947

Merged
merged 3 commits into from
Jun 6, 2021
Merged

Refactor scrollbar.js to be used as a Class #33947

merged 3 commits into from
Jun 6, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented May 12, 2021 •
edited
Loading

Background:

This Pr:

@GeoSot GeoSot force-pushed the gs-refactor-scrollbar-to-class branch from 79d3aec to 83c77bb Compare May 20, 2021 13:49
@GeoSot GeoSot marked this pull request as ready for review May 20, 2021 13:52
@GeoSot GeoSot requested a review from a team as a code owner May 20, 2021 13:52
@GeoSot GeoSot force-pushed the gs-refactor-scrollbar-to-class branch 5 times, most recently from fe2f21b to d6d54b9 Compare May 24, 2021 15:57
@GeoSot GeoSot force-pushed the gs-refactor-scrollbar-to-class branch from d6d54b9 to b264b5a Compare May 31, 2021 12:23
@GeoSot GeoSot force-pushed the gs-refactor-scrollbar-to-class branch from b264b5a to 760726e Compare June 2, 2021 12:41
@GeoSot GeoSot force-pushed the gs-refactor-scrollbar-to-class branch from 760726e to 0d6e263 Compare June 3, 2021 22:45
@GeoSot GeoSot requested a review from rohit2sharma95 June 4, 2021 10:25
@XhmikosR XhmikosR changed the title Refactor ScrollBar.js to be used as class Refactor scrollbar.js to be used as class Jun 6, 2021
@XhmikosR XhmikosR changed the title Refactor scrollbar.js to be used as class Refactor scrollbar.js to be used as a Class Jun 6, 2021
@XhmikosR XhmikosR merged commit cb47b8c into main Jun 6, 2021
@XhmikosR XhmikosR deleted the gs-refactor-scrollbar-to-class branch June 6, 2021 06:26
marvin-hinkley-vortx pushed a commit to Vortx-Inc/bootstrap that referenced this pull request Aug 18, 2021
@GeoSot @marvin-hinkley-vortx
Refactor scrollbar.js to be used as a Class (twbs#33947)
580d3c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpadev alpadev alpadev approved these changes

@rohit2sharma95 rohit2sharma95 Awaiting requested review from rohit2sharma95

Assignees
No one assigned
Labels
js refactoring v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeoSot @alpadev @XhmikosR