Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to SASS division #34115

Closed
wants to merge 4 commits into from
Closed

Migrate to SASS division #34115

wants to merge 4 commits into from

Conversation

rohrlaf
Copy link

@rohrlaf rohrlaf commented May 26, 2021

Fixes #34051

SASS will introduce a breaking change with Slash as Division: https://sass-lang.com/documentation/breaking-changes/slash-div

Running the migrator twice, as _rfs.scss contains nested division, will use the new functionality:

$ npx sass-migrator division **/*.scss

@rohrlaf rohrlaf requested a review from a team as a code owner May 26, 2021 06:31
@XhmikosR
Copy link
Member

Please read our contribution guidelines and don't commit any dist files. As for the @use change, @ffoodd @mdo we don't use it anywhere else right now.

@XhmikosR XhmikosR marked this pull request as draft May 26, 2021 08:27
@ffoodd
Copy link
Member

ffoodd commented May 26, 2021

If I recall correctly previous discussions, using @use will break Libsass compatibility, which is both a BC and a pain for most of our users.

@rohrlaf
Copy link
Author

rohrlaf commented May 26, 2021

Please read our contribution guidelines and don't commit any dist files. As for the @use change, @ffoodd @mdo we don't use it anywhere else right now.

Okaya, why not add them to .gitignore? As they were not ignored, I thought you might need them for distribution in the VCS.

If I recall correctly previous discussions, using @use will break Libsass compatibility, which is both a BC and a pain for most of our users.

Totally forgot about this, you are right. node-sass is still quite popular and runs on LibSass. I will close this PR, as this is no real feasible fix for now.

@rohrlaf rohrlaf closed this May 26, 2021
@rohrlaf rohrlaf deleted the fix/sass-division branch May 26, 2021 11:29
@mmarton
Copy link

mmarton commented May 26, 2021

https://www.npmjs.com/package/node-sass

Warning: LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases indefinitely, there are no plans to add additional features or compatibility with any new CSS or Sass features. Projects that still use it should move onto Dart Sass.

keeping the source cross compatible with deprecated tools is nice, but blocks progress

@ffoodd
Copy link
Member

ffoodd commented May 26, 2021

@rohrlaf We want out dist files ton ne distributed and that's the simplest way. Discussions are still opened regarding this strategy but we already had plenty and always chose to keep this way.

@mmarton Well we work for out users, not for their tools. This Sass strategic change might help but we're not there yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sass deprecation warning: Using / for division is deprecated
4 participants