-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs offcanvas navbar #34487
Docs offcanvas navbar #34487
Conversation
3c9a521
to
72e79d0
Compare
71c139e
to
af93efb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We seem to use 1.25rem
a lot indeed, setting a new variable might help a bit.
Regarding docs sidebar, I don't think it should be using offcanvas. Having two different navs help in identifying them , IMHO. But that's more a UX decision, my opinion might not have much value :D
The PR is looking fine as-is, and is working fine AFAIC.
Opted not to do a CSS variable here since on .bd-content it would be inherited into our examples
f44fb00
to
9d659ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👌
Work in progress to update our docs navbar for v5.2.0 to use the offcanvas navbar styles.
Preview: https://deploy-preview-34487--twbs-bootstrap.netlify.app/