-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer Linux-specific fonts over Arial #34547
Conversation
Thanks for opening this! If we go this way, wouldn't it be better to drop Same concern regarding Roboto, since it's an alias for Arial too. Not quite sure about side-effects on Android though, since if Noto Sans is available on Android it'd pick that instead of falling back to Roboto as an Arial alias. |
I'm not really familiar enough with the specifics of Arial-proper and the various fallbacks that various distros provide depending on what set of installed packages to feel confident to suggest much change beyond what I'm suggesting here, I think. That doesn't mean that I would oppose going further, but I don't think that would be a change I would want to put my name on, simply because I don't feel like I've done enough research on the matter. |
Fair enough 👌 IMHO this is good. Just remembered that on Ubuntu at least, dropping |
@ffoodd: Anything I can do to help moving this forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just tried a few variants on Ubuntu and this feels safe. Using Arial as a generic fallback looks like a good idea, IMHO. Thanks!
@ffoodd: As a first-time contributor, I need someone to approve running the workflows. Would you mind doing that? :) |
Some Linux distributions (like Debian) have fontconfig aliases for Arial that picks specific fonts. But such generic aliases might be less desirable than the known-good Linux specific fonts. This fixes a problem on my setup where Liberation Sans is aliased as Arial, even when Noto Sans is available. Liberation Sans doesn't support a weight of 500, so we end up rendering headers at the normal weight of 400, which makes them stand out less. Reordering the Arial fallback makes us instead pick Noto Sans over Lieration Sans, which does support a weight of 500, and makes headers stand out again. While we're at it, fixup the reboot documentation to match, and change the comment about Helvetica Neue; that's not a "Basic web-fallback" font, it's the UI font on older iOS and macOS versions.
Some Linux distributions (like Debian) have fontconfig aliases for Arial
that picks specific fonts. But such generic aliases might be less
desirable than the known-good Linux specific fonts.
This fixes a problem on my setup where Liberation Sans is aliased as
Arial, even when Noto Sans is available. Liberation Sans doesn't support
a weight of 500, so we end up rendering headers at the normal weight of
400, which makes them stand out less. Reordering the Arial fallback
makes us instead pick Noto Sans over Lieration Sans, which does support
a weight of 500, and makes headers stand out again.
While we're at it, fixup the reboot documentation to match, and change
the comment about Helvetica Neue; that's not a "Basic web-fallback" font,
it's the UI font on older iOS and macOS versions.