Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color input validation icon #34863

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Color input validation icon #34863

merged 1 commit into from
Mar 1, 2022

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Sep 1, 2021

Fixes #34151

This might not be ideal but should not break things. Any thoughts?


Screenshot:
image

@ffoodd ffoodd requested a review from a team as a code owner September 1, 2021 14:13
@ffoodd ffoodd changed the title fix(forms): validated color input Color input Sep 1, 2021
@ffoodd ffoodd changed the title Color input Color input validation icon Sep 1, 2021
@mdo
Copy link
Member

mdo commented Sep 1, 2021

The box-sizing change, if someone gives this a fixed height, that'd cause an issue, right? Anyway to avoid that change?

@ffoodd
Copy link
Member Author

ffoodd commented Sep 2, 2021

The only way around I can think of is adjusting the width in validation styles, to account for the extended padding.

Does this sound better to you?

@alecpl
Copy link
Contributor

alecpl commented Sep 5, 2021

There is a 3rd option. Get rid of max-width and handle color inputs as any other input. Imo, that's the best option.

@ffoodd
Copy link
Member Author

ffoodd commented Sep 6, 2021

Indeed, but that may break things too if one accounted for this small width already.

@mdo
Copy link
Member

mdo commented Sep 6, 2021

The only way around I can think of is adjusting the width in validation styles, to account for the extended padding.

Yeah, I think that sounds the best at this point. We can maybe revisit for v6 then?

@ffoodd ffoodd force-pushed the main-fod-invalid-color-inputs branch from 126ca05 to ca68afe Compare October 20, 2021 10:19
@ffoodd
Copy link
Member Author

ffoodd commented Oct 20, 2021

@mdo antoher call for this, by simply handling width to account for padding.

@ffoodd ffoodd force-pushed the main-fod-invalid-color-inputs branch from ca68afe to 5ac01c0 Compare October 20, 2021 19:09
@ffoodd
Copy link
Member Author

ffoodd commented Feb 28, 2022

Up on this, I think it's pretty safe :)

@mdo mdo force-pushed the main-fod-invalid-color-inputs branch from 5ac01c0 to 22fe14a Compare March 1, 2022 03:29
@mdo mdo merged commit 954f6e5 into main Mar 1, 2022
@mdo mdo deleted the main-fod-invalid-color-inputs branch March 1, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

form-control-color should not use validation icons
4 participants