Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add Callout to Stacks Helper page about limited flexbox gap support #34910

Merged
merged 4 commits into from
Sep 6, 2021
Merged

Docs: Add Callout to Stacks Helper page about limited flexbox gap support #34910

merged 4 commits into from
Sep 6, 2021

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Sep 6, 2021

Fixes: #34737

Preview screenshot from localhost
localhost_9001_docs_5 1_helpers_stacks_(iPad Pro)

@GeoSot GeoSot requested a review from mdo September 6, 2021 12:05
@GeoSot GeoSot added the docs label Sep 6, 2021
@XhmikosR
Copy link
Member

XhmikosR commented Sep 6, 2021

If this only for one page, it doesn't need to be a partial

@XhmikosR XhmikosR added the v5 label Sep 6, 2021
@coliff
Copy link
Contributor Author

coliff commented Sep 6, 2021

Do you think it's needed on the Gap utilities page too?
https://getbootstrap.com/docs/5.1/utilities/spacing/#gap
I personally don't think it's needed there as that section only talks about Grid gap (not flexbox gap)
cc @mdo

@XhmikosR
Copy link
Member

XhmikosR commented Sep 6, 2021

I'll defer this to @mdo, but if it's only one place then we don't need the partial :)

@mdo
Copy link
Member

mdo commented Sep 6, 2021

Yeah we can skip the partial and do just the one page :)

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving for when the partial is removed :).

@XhmikosR XhmikosR merged commit 6411799 into twbs:main Sep 6, 2021
@mdo
Copy link
Member

mdo commented Sep 6, 2021

Thank you both!

@coliff coliff deleted the dev/coliff/docs-flexbox-gap-warning branch September 6, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stacks with Gaps don't have gaps in all supported browsers (e.g. iOS 12)
4 participants