-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSS color variables to Card component #35097
Conversation
911d943
to
66f027e
Compare
This is off to a great start! For |
Hi! Apologies for the silence
Could you please clarify this? |
66f027e
to
7050d85
Compare
@tagliala I meant something like this: cursor: if($enable-button-pointers, pointer, null); That said, it might be fine to have some unused variables lying around for now provided we have a documented approach for them. Unused or |
7050d85
to
cc57fa8
Compare
Hello, I've rebased this PR on master and I've replaced all card scss variables into css variables About the definitions, I've used the same order of scss variables, but I know that the css is different The conversion is based on an automatic find and replace to prevent typos Feel free to take over this PR |
Closed for #36059. |
Hi, this is an attempt to provide variables for the Card component, but I have a couple of questions
$card-color
and$card-cap-color
are defined asnull
. This has the effect of rules being generated with SCSS, but it will generate empty css variables.inherit
?null
toinherit
, should it be considered a breaking change?@if $nav-tabs-link-active-bg != $card-bg
moved out fromif
?