Fix a few more SSR problems #35165
Closed
Fix a few more SSR problems #35165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Thank you @xvaara ❤️ |
GeoSot
force-pushed
the
jo-ssr-friendly
branch
from
4a78b80 to
dd315ad
Compare
|
@xvaara please don't include any dist files. Also, try to rebase your branch. If you can't, just let me know and I'll do the rebase (just please make sure you don't overwrite the changes) |
XhmikosR
added
the
skip-changelog
XhmikosR
force-pushed
the
jo-ssr-friendly
branch
from
87b3fdb to
47d96a7
Compare
XhmikosR
force-pushed
the
jo-ssr-friendly
branch
from
dd315ad to
d49a667
Compare
XhmikosR
force-pushed
the
jo-ssr-friendly
branch
from
47d96a7 to
a3518e0
Compare
XhmikosR
force-pushed
the
jo-ssr-friendly
branch
from
d49a667 to
426235a
Compare
XhmikosR
force-pushed
the
jo-ssr-friendly
branch
from
a3518e0 to
aaf41b3
Compare
GeoSot
reviewed
Nov 2, 2021
| @@ -150,7 +150,7 @@ function normalizeParams(originalTypeEvent, handler, delegationFn) { | |||
| } | |||
|
|
|||
| function addHandler(element, originalTypeEvent, handler, delegationFn, oneOff) { | |||
| if (typeof originalTypeEvent !== 'string' || !element) { | |||
| if (typeof originalTypeEvent !== 'string' || !element || !element.addEventListener) { | |||
There was a problem hiding this comment.
@xvaara can you define the reason of this change?
GeoSot
reviewed
Nov 2, 2021
| @@ -321,7 +321,7 @@ const getWindow = () => { | |||
| * @return {document|{}} The proper element | |||
| */ | |||
| const getDocument = () => { | |||
| return typeof document !== 'undefined' ? document : {} | |||
| return typeof document !== 'undefined' ? document : { documentElement: {} } | |||
There was a problem hiding this comment.
@xvaara can you define the reason of this change, too?
|
Closing it as not answered. The focusTrap changes transferred to #34989 |
GeoSot
added a commit
that referenced
this pull request
Nov 8, 2021
|
I did answer... ? @GeoSot are the review comment replies not the right place to answer? |
xvaara
added a commit
to xvaara/bootstrap
that referenced
this pull request
Nov 8, 2021
* upstream/jo-ssr-friendly: some updates on focustrap (based on twbs#35165) Move ESLint config to an override add swipe, add @doc use a ternary Be SSR friendly when accessing DOM objects Fix spacing utility classes mentioned in navbar supported content documentation (twbs#35328) README.md remove broken "David DM" dependency badges (twbs#35313) Update import stacks required for modifying utilities (twbs#35320) Add top placement info to offcanvas docs
GeoSot
added a commit
that referenced
this pull request
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested SSR render with bootstrap-vue-3. Found these.