-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rely on border-width
for <hr>
size
#35491
Conversation
<hr>
size
<hr>
sizeborder-width
for <hr>
size
So while this makes sense to me, it is a breaking change. |
AFAIC We're pretty fine here, but we already have two issues around Does this sound better? |
Co-authored-by: Mark Otto <markd.otto@gmail.com>
Fixes #34292, fixes #34374, fixes #35616.
A few tries confirmed me that relying on
border-width
as in v4 doesn't imply any side effect, even when using the (deprecated)size
attribute.I don't see any reason to stick with
height
then, so ditching this to make our newhr
closer to v4.Contrary to what we said in #34574, we can keep the opacity feature this way. With my current proposal, customizing
hr
could be done using.text-*
for color and.border-*
for sizing. I'd stick tocurrentColor
for color since it allows inheritance: relying onborder-color
would require us to define a value (as it was done in v4) but I think it's more valuable to inherit from text color, isn't it?NB: the current migration guide mentions v5.2.0, which is not accurate, is it? Do we maintain a minor versions' migration guide anywhere?