src/tooltip.js Optimization

[dilyanpalauzov]

Util.findShadowRoot() returns either null or an object.

It cannot return falsy, which allows this optimization.

[alecpl]

Maybe something like this could work too?:

--- a/js/src/tooltip.js
+++ b/js/src/tooltip.js
@@ -245,12 +245,11 @@ class Tooltip extends BaseComponent {
     }
 
     const showEvent = EventHandler.trigger(this._element, this.constructor.Event.SHOW)
-    const shadowRoot = findShadowRoot(this._element)
-    const isInTheDom = shadowRoot === null ?
-      this._element.ownerDocument.documentElement.contains(this._element) :
-      shadowRoot.contains(this._element)
 
-    if (showEvent.defaultPrevented || !isInTheDom) {
+    if (showEvent.defaultPrevented
+      || findShadowRoot(this._element)
+      || !this._element.ownerDocument.documentElement.contains(this._element)
+    ) {
       return
     }