Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add !important property to colored links #35740

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Add !important property to colored links #35740

merged 2 commits into from
Feb 17, 2022

Conversation

nalakapws
Copy link
Contributor

It would be great if we can use colored links in components like navbar items to color them.

Thanks.

@nalakapws nalakapws requested a review from a team as a code owner January 28, 2022 12:50
ffoodd
ffoodd approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I agree the use case should be taken into account, and this is the simplest way around.

I don't think there could be any specificity issue here since applying the helper probably means you want the color to apply.

@mdo mdo force-pushed the add-!important-property-to-colored-links branch from 348b3ce to 2d158c0 Compare February 17, 2022 18:11
mdo
mdo reviewed Feb 17, 2022
View reviewed changes
scss/helpers/_colored-links.scss Outdated Show resolved Hide resolved
scss/helpers/_colored-links.scss Outdated Show resolved Hide resolved
@mdo mdo force-pushed the add-!important-property-to-colored-links branch from f051a50 to 050b539 Compare February 17, 2022 18:24
@mdo mdo merged commit 999bfaa into twbs:main Feb 17, 2022
@arthurshlain arthurshlain mentioned this pull request Mar 5, 2022
Closed
@XhmikosR XhmikosR changed the title Add !important property to colored links. Add !important property to colored links Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@ffoodd ffoodd ffoodd approved these changes

Assignees
No one assigned
Labels
css v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nalakapws @mdo @ffoodd