Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown.js optimizations #35748

Merged
merged 3 commits into from
Jan 30, 2022
Merged

Dropdown.js optimizations #35748

merged 3 commits into from
Jan 30, 2022

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Jan 30, 2022

No description provided.

@GeoSot GeoSot requested a review from a team as a code owner January 30, 2022 15:38
@GeoSot GeoSot force-pushed the gs/dropdown-patch branch from cd7cf5f to d62ec1c Compare January 30, 2022 15:46
tacosontitan
tacosontitan reviewed Jan 30, 2022
View reviewed changes
Copy link

@tacosontitan tacosontitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

@GeoSot GeoSot force-pushed the gs/dropdown-patch branch from d62ec1c to c8d4a25 Compare January 30, 2022 15:53
tacosontitan
tacosontitan reviewed Jan 30, 2022
View reviewed changes
Copy link

@tacosontitan tacosontitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

@XhmikosR XhmikosR merged commit 7f04f84 into main Jan 30, 2022
@XhmikosR XhmikosR deleted the gs/dropdown-patch branch January 30, 2022 16:01
@louismaximepiton louismaximepiton mentioned this pull request Aug 23, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacosontitan tacosontitan tacosontitan left review comments

@XhmikosR XhmikosR XhmikosR approved these changes

Assignees
No one assigned
Labels
js no squash v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeoSot @XhmikosR @tacosontitan