Replace non-existent --bs-btn-padding by --bs-btn-padding-{x|y}
#35886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
approved these changes
Feb 23, 2022
ffoodd
approved these changes
Feb 23, 2022
|
I've created #35890 because I'm not sure to have the time soon to fix it in a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--#{$variable-prefix}btn-paddingdoesn't exist so the custom sizing button with CSS variables is not fully functional.In this fix, I chose to keep 2 separate vars but it could probably be only 1 var.
Preview
Note: there is another bug that can be seen in this page: the last buttons are not vertically aligned with the other buttons in a same row in the examples. It is probably due to the new rule in 37f3977:
I can create an issue if needed.