Updated the small-font-size to use a round value #36172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backport from BS5 to BS4. As per twbs#35553 The ```small-font -size``` will actually increase from ```13px``` to ```14px``` with this proposed change. Personally I'd prefer keeping it the BS5 way (```14px```), as the text is more readable now. If it's needed, I can do another PR with the ```$small-font-size: .8125rem !default;``` to resemble BS4 more closely but I feel like this would be a move forward even for BS4.
1 task
This was referenced Sep 23, 2024
This was referenced Sep 30, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport from BS5 to BS4.
It fixes #35553 (for the vast majority of cases) and also increases text legibility.
The
small-font-sizewill actually increase from13pxto14pxwith this change. Personally I prefer doing it the BS5 way (14px), as the text is more readable now.If it's needed, I can do another PR with the
$small-font-size: .8125rem !default;to resemble BS4 more closely but I feel like this would be a move forward even for BS4.