Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: remove role="group" from some split drop* buttons #36212

Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Apr 23, 2022

Description

  • Remove role="group" from the split dropstart button in the documentation
  • Remove role="group" from visual JS tests

Motivation & Context

Since v4.6.1 (at least), the split dropstart button example in the documentation has a role="group". But this is the only example having it.

We don't see this role for split dropend and split dropup, and "normal" split buttons.

This PR brings more consistency in the examples by removing this extra-role.

⚠️ However, I don't have the expertise to say if it could be useful in terms of a11y. In this case, this PR should rather be updated to add this role wherever it is useful.

Note: Since it is observed in v4.x as well, whatever the final modification will be, I suppose it could be backported in v4 as well.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • All new and existing tests passed

Related issues

N/A

Live preview

@mdo
Copy link
Member

mdo commented Apr 29, 2022

/cc @patrickhlauke

@patrickhlauke
Copy link
Member

i don't think there's any accessibility advantage in using role="group" in this case, no. so i'd say go for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants