-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4: Horizontal collapse #36434
v4: Horizontal collapse #36434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👌
IDK if anything must be done in the v5 migration guide. At the moment we have:
Collapse plugin now supports horizontal collapsing. — Add .collapse-horizontal to your .collapse to collapse the width instead of the height. Avoid browser repainting by setting a min-height or height.
Depending from which version you start and to which version you go you have several scenarios.
- v4 (<v4.7.0) → v5 (>=v5.1.0): Collapse plugin now supports horizontal collapsing
- v4.7.0 → v5.0.0: Collapse plugin doesn't exist anymore
- v4.7.0 → v5 (>=v5.1.0):
.width
must be changed to.collapse-horizontal
488ee2f
to
4c06e34
Compare
Backports #34253 to v4. Changes the
collapse-horizontal
towidth
for those who've secretly been using this feature for years in Bootstrap 4 but never saw official support.