Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4: Improve accessible name of version dropdown in docs navbar #36504

Merged
merged 3 commits into from
Jun 5, 2022
Merged

v4: Improve accessible name of version dropdown in docs navbar #36504

merged 3 commits into from
Jun 5, 2022

Commits on Jun 4, 2022

  1. Improve accessible name of version dropdown in docs navbar 

    - add separate visually-hidden "Bootstrap", which will be part of the accessible name regardless of whether the other string is visible or not (on large screen)
- extra visually-hidden text to give some context - that the dropdown is about switching versions
- remove the redundant id/aria-labelledby for the dropdown
    @patrickhlauke
    patrickhlauke committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    dde6406 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'v4-dev' into patrickhlauke-improve-docs-navbar-version-… 

    …dropdown-v4
    @patrickhlauke
    patrickhlauke authored Jun 4, 2022
    Configuration menu
    Copy the full SHA
    0989859 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2022

  1. Change version dropdown trigger to <button>

    @patrickhlauke
    patrickhlauke committed Jun 5, 2022
    Configuration menu
    Copy the full SHA
    5d3330e View commit details
    Browse the repository at this point in the history