Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new css vars for Offcanvas #36815

Merged
merged 3 commits into from
Oct 3, 2022

Conversation

isabellechanclou
Copy link
Contributor

Proposal to add 3 new css variables for Offcanvas feature.

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little changes before we can approve and slate for v5.3.0 :).

@@ -41,7 +44,7 @@
background-clip: padding-box;
outline: 0;
@include box-shadow(var(--#{$prefix}offcanvas-box-shadow));
@include transition(transform $offcanvas-transition-duration ease-in-out);
@include transition(transform var(--#{$prefix}offcanvas-transition-duration) ease-in-out);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be a variable for the entire property value, not just the duration.

--bs-offcanvas-transition: transform #{$offcanvas-transition-duration} ease-in-out);

scss/_offcanvas.scss Outdated Show resolved Hide resolved
@mdo mdo merged commit 838deba into twbs:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants