Search modal: Set cursor on auto #37027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
This fix LGTM!
I'm also wondering why there's a [role="button"] for this container. It is mentioned in @patrickhlauke issue algolia/docsearch#1370. Maybe you can just add a comment along with your patch with the reference of this issue and why we need to add this patch; it will allow us in the future to remove this line if it becomes useless.
julien-deramond
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search container
.DocSearch-Containercontains a[role="button"]leading to a pointer cursor on every part of the modal. This is just a quick fix, but I'm actually wondering why there is that[role="button"]on that container. I should maybe open an issue on Algolia side ?