Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btn-group draws first input margin #36794 #37080

Merged
merged 2 commits into from
Sep 5, 2022
Merged

btn-group draws first input margin #36794 #37080

merged 2 commits into from
Sep 5, 2022

Conversation

amirhosseinfaraji
Copy link
Contributor

fix #36794

@amirhosseinfaraji amirhosseinfaraji requested a review from a team as a code owner September 3, 2022 22:43
@mdo
Copy link
Member

mdo commented Sep 4, 2022

Downside to this solution is that if someone is using <a> and <button> elements in the same button group. https://codepen.io/emdeoh/pen/WNJbvNw?editors=1100

@amirhosseinfaraji
Copy link
Contributor Author

amirhosseinfaraji commented Sep 4, 2022 •
edited
Loading

@mdo you're right. I updated with :not(.btn-check:first-child) + .btn selector

mdo
mdo approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codepen I made looks good, so approving and merging. Thanks!

@mdo mdo force-pushed the btn-group-draws-first-input-margin branch from 250103b to 699e745 Compare September 5, 2022 19:47
@mdo mdo merged commit 9b94388 into twbs:main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
css v5
Projects
No open projects
v5.2.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

btn-group draws first input margin outside due to negative margin
3 participants
@amirhosseinfaraji @mdo @julien-deramond