Add $enable-important-utilities condition in colored links

[julien-deramond]

Description

As mentioned in the issue !important was set whatever if $enable-important-utilities was true or false for colored links. This PR adds a new condition as it is already done for other utilities.

Type of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist

• I have read the contributing guidelines
• My code follows the code style of the project (using npm run lint)
• All new and existing tests passed

How to test

Check with/without enabling $enable-important-utilities to run npm run css.

When enabled:

.link-primary {
  color: #0d6efd !important;
}
.link-primary:hover, .link-primary:focus {
  color: #0a58ca !important;
}

When disabled:

.link-primary {
  color: #0d6efd;
}
.link-primary:hover, .link-primary:focus {
  color: #0a58ca;
}

Related issues

Closes #37251

[mdo]

I get why we should do this one, but helpers aren't utilities and this Sass variable is primarily for utilities. Thoughts?

[julien-deramond]

I get why we should do this one, but helpers aren't utilities and this Sass variable is primarily for utilities. Thoughts?

Atm it is done like this in _color-bg.scss as well. But you're right. Since the target release is the v5.3.0, we could create a $enable-important-helpers to use there and explain in the migration guide or somewhere else that something has changed for .text-bg-*. What do you think of this proposal?

[mdo]

Meh, let's roll with this for now :). We can revisit later if needed.

[narbehm]

I get why we should do this one, but helpers aren't utilities and this Sass variable is primarily for utilities. Thoughts?

Atm it is done like this in _color-bg.scss as well. But you're right. Since the target release is the v5.3.0, we could create a $enable-important-helpers to use there and explain in the migration guide or somewhere else that something has changed for .text-bg-*. What do you think of this proposal?

Maybe the time is now? The default behavior of !important for link colors breaks many use cases where the default classes are overridden in some custom theme. Unfortunately setting $enable-important-utilities to false affects other behavior that we don't want. Being able to turn this feature off only for colored links would be a plus.