-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home imports #37318
Home imports #37318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments for this PR but the overall is good. Like the new architecture and the small improvements that make the difference.
Great feedback all around! Just pushed up some changes to address everything here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My last 2 comments regarding this PR and I think we're good to go 🚀
This comment was marked as off-topic.
This comment was marked as off-topic.
Also modifies the homepage code snippets under getting started to remove the code comments, making copy-pasting easier.
This PR breaks up the homepage's
masthead-followup.html
partial into more manageable pieces. Made some copy changes alongside it. Fair warning, this might need another pass from me yet—I did this a couple weeks ago and forgot to push the branch until now.