Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _floating-labels.scss #37321

Closed
wants to merge 5 commits into from
Closed

Update _floating-labels.scss #37321

wants to merge 5 commits into from

Conversation

jonnysp
Copy link
Contributor

@jonnysp jonnysp commented Oct 14, 2022

Closes #37330

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@jonnysp jonnysp requested a review from a team as a code owner October 14, 2022 07:30
@julien-deramond
Copy link
Member

Thanks for your PR @jonnysp but it's already taken care of in #37299

@julien-deramond
Copy link
Member

julien-deramond commented Oct 17, 2022

Sorry @jonnysp. I hadn't noticed the 2 fixes in this PR. I've reopened it and changed the description to close #37330. Can you update it in order to tackle only this issue? I'll look at it in details asap.

@jonnysp
Copy link
Contributor Author

jonnysp commented Oct 17, 2022

@julien-deramond
No Problem

@jonnysp jonnysp closed this by deleting the head repository Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot activate Floating labels
2 participants