Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: use 'added' page information to display a tag on top of the pages #37341

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Oct 19, 2022

Description

In some of our Markdown files, we got an added information but apparently we never display that information:

---
layout: docs
title: Color & background
description: Set a background color with contrasting foreground color.
group: helpers
toc: true
added: "5.2"
---

This PR suggests to use this information and to display it on top of the corresponding pages next to the "View on GitHub" button.

Screenshot 2022-10-19 at 11 30 16

Motivation & Context

Bring more information to the users about the latest changes.

Type of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review October 19, 2022 09:30
@XhmikosR XhmikosR merged commit ec68f3d into main Oct 25, 2022
@XhmikosR XhmikosR deleted the main-jd-use-page-added-in branch October 25, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants