Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint: enable prefer-template rule #37484

Merged
merged 1 commit into from
Nov 12, 2022
Merged

ESLint: enable prefer-template rule #37484

merged 1 commit into from
Nov 12, 2022

Conversation

XhmikosR
Copy link
Member

No description provided.

@XhmikosR XhmikosR marked this pull request as ready for review November 12, 2022 07:44
@XhmikosR XhmikosR requested a review from a team as a code owner November 12, 2022 07:44
julien-deramond
julien-deramond approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just a comment here. Since we have "prefer-template": "error" set in the main .eslintrc.json, you could probably remove this rule from site/.eslintrc.json because it is, I suppose, inherited.

@XhmikosR
Copy link
Member Author

Yeah, I have the site/.eslintrc.json cleanup in another patch 1d5d58e

@XhmikosR XhmikosR changed the title Enable prefer-template rule ESLint: enable prefer-template rule Nov 12, 2022
@XhmikosR XhmikosR merged commit 5208dd1 into main Nov 12, 2022
@XhmikosR XhmikosR deleted the xmr/prefer-template branch November 12, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
js v5
Projects
No open projects
v5.3.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @julien-deramond