Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS: Proposal to rename the CSS and Sass variables for .*-text-emphasis #37907

Merged
merged 1 commit into from
Jan 21, 2023
Merged

CSS: Proposal to rename the CSS and Sass variables for .*-text-emphasis #37907

merged 1 commit into from
Jan 21, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jan 17, 2023 •
edited
Loading

Description

Rename Sass and CSS variables *-text to *-text-emphasis.

Motivation & Context

Have some consistency between the variables and the classes used.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

NA

@louismaximepiton louismaximepiton requested a review from a team as a code owner January 17, 2023 15:36
@louismaximepiton louismaximepiton mentioned this pull request Jan 17, 2023
Merged
85 tasks
mdo
mdo approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig. Thanks!

@mdo mdo merged commit 15744ee into twbs:main Jan 21, 2023
@louismaximepiton louismaximepiton deleted the main-lmp-sass-rename branch January 23, 2023 07:22
@cccabinet cccabinet mentioned this pull request Feb 5, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
color mode css v5
Projects
No open projects
v5.3.0-alpha2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louismaximepiton @mdo