Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop duplicate $nav-link-disabled-color declaration #38083

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Drop duplicate $nav-link-disabled-color declaration #38083

merged 2 commits into from
Feb 23, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Feb 20, 2023 •
edited
Loading

Description

This PR suggests dropping one of the two $nav-link-disabled-color. I supposed that we prefer to set it with the CSS var instead of $gray-500 based on our recent work around color mode. But I might be wrong; there are some edge cases sometimes :)

Type of changes

  • Enhancement (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (N/A) My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review February 20, 2023 08:14
@julien-deramond julien-deramond requested a review from a team as a code owner February 20, 2023 08:14
@julien-deramond julien-deramond mentioned this pull request Feb 20, 2023
Merged
mdo
mdo approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should definitely be the new CSS variable. Thanks!

@julien-deramond julien-deramond merged commit afd3736 into main Feb 23, 2023
@julien-deramond julien-deramond deleted the main-jd-drop-duplicate-nav-disabled-color-init branch February 23, 2023 06:59
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
color mode css v5
Projects
No open projects
v5.3.0-alpha2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-deramond @mdo