Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing modifications when --bs-{color}-text was changed to --bs-{color}-text-emphasis #38176

Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Mar 6, 2023

Description

15744ee introduced the following change: bs-{color}-textbs-{color}-text-emphasis

This PR fixes some missing modifications in:

  • scss/tests/mixins/_color-modes.test.scss
  • scss/_variables.scss that fixes the rendering of the active text color in both light and dark modes

Please double-check that we haven't forgotten other things with different combinations of --bs-{color}-text and/or --#{$prefix}{color}-text.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (N/A) My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond merged commit 833da72 into main Mar 7, 2023
@julien-deramond julien-deramond deleted the main-jd-fix-missing-modification-for-text-emphasis branch March 7, 2023 05:45
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants