Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update float responsive examples #38885

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Docs: Update float responsive examples #38885

merged 1 commit into from
Jul 24, 2023

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Jul 10, 2023

Description

Switch example to use float-end rather than float-start, so it's possible to see/test how they work by resizing the browser window. Right now they are always left-aligned.

Also adds missing xxl variant example.

Motivation & Context

to show users all variants and how they work.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, I agree that it's more handy to see and understand the effect by using .float-*-end utilities here. And good catch for the xxl missing one.

@mdo mdo merged commit ea21de1 into twbs:main Jul 24, 2023
@coliff coliff deleted the patch-3 branch July 24, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants