Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dark mode rendering of Cheatsheet examples #38905

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fix dark mode rendering of Cheatsheet examples #38905

merged 1 commit into from
Jul 17, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jul 15, 2023 •
edited
Loading

Description

This PR fixes the dark mode rendering of Cheatsheet examples.
I chose to apply minimal changes to make it work rather well: using the body color and some grays working both in light and dark modes.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #38904

@julien-deramond julien-deramond marked this pull request as ready for review July 15, 2023 06:35
@julien-deramond julien-deramond requested a review from a team as a code owner July 15, 2023 06:35
@mdo mdo merged commit b3da789 into main Jul 17, 2023
@mdo mdo deleted the main-jd-fix-dark-mode-rendering-of-cheatsheet-examples branch July 17, 2023 03:48
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
@julien-deramond @romankupchak93
Fix dark mode rendering of Cheatsheet examples (twbs#38905)
86d3caf
@lukegeor lukegeor mentioned this pull request May 18, 2024
Open
This was referenced May 19, 2024
Open
Open
@Hamberfim Hamberfim mentioned this pull request May 21, 2024
Merged
@V1CTORY360 V1CTORY360 mentioned this pull request May 22, 2024
Open
This was referenced May 24, 2024
Open
Open
@devcurt696 devcurt696 mentioned this pull request May 24, 2024
Open
@suryaelidanto suryaelidanto mentioned this pull request May 24, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@Guiguiiz92 Guiguiiz92 mentioned this pull request May 24, 2024
Open
@Cpano Cpano mentioned this pull request May 24, 2024
Open
@zxcv32 zxcv32 mentioned this pull request May 24, 2024
Open
@rawanst rawanst mentioned this pull request May 24, 2024
Open
@V1CTORY360 V1CTORY360 mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@ngochoangg ngochoangg mentioned this pull request May 24, 2024
Open
@jadsongmatos jadsongmatos mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@GTVolk GTVolk mentioned this pull request Sep 14, 2024
Open
@Cpano Cpano mentioned this pull request Sep 17, 2024
Open
@GTVolk GTVolk mentioned this pull request Sep 17, 2024
Open
@Cpano Cpano mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 18, 2024
Open
Open
Open
Open
Open
@AndresElacion AndresElacion mentioned this pull request Sep 24, 2024
Open
@castle2668 castle2668 mentioned this pull request Sep 24, 2024
Merged
This was referenced Sep 25, 2024
Open
Open
Open
@pinco227 pinco227 mentioned this pull request Sep 27, 2024
Open
This was referenced Sep 28, 2024
Open
Open
@lisagorewitdecker lisagorewitdecker mentioned this pull request Sep 30, 2024
Merged
This was referenced Sep 30, 2024
Open
Open
@Akhamesra Akhamesra mentioned this pull request Oct 2, 2024
Open
@YnnusAsamal YnnusAsamal mentioned this pull request Oct 3, 2024
Open
@jtprogru jtprogru mentioned this pull request Oct 5, 2024
Open
@Gutts-n Gutts-n mentioned this pull request Oct 5, 2024
Open
@Kimahari Kimahari mentioned this pull request Oct 5, 2024
Open
This was referenced Oct 12, 2024
Open
Open
Open
Open
@Arrhenius09 Arrhenius09 mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
color mode examples v5
Projects
No open projects
v5.3.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cheatsheet v5.3 not rendering correctly in dark mode
2 participants
@julien-deramond @mdo