Examples: Introduce <skip> for our examples + Add some Stackblitz examples + undupe code + homogenize our design for the examples in the doc
#38933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Haven't looked at it in detail, but love it so far! This is neat! More StackBlitz and less (and probably get rid of) |
|
Can you please fix your PR title and commits to be more descriptive please? |
louismaximepiton
changed the title
<skip> for our examples + Add some Stackblitz examples + undupe code + homogenize our design for the examples in the doc
XhmikosR
reviewed
Jul 25, 2023
| </div> | ||
| </div> | ||
| </div> | ||
| ``` | ||
| {{< /example >}} |
There was a problem hiding this comment.
indentation is off, there might be more places
XhmikosR
reviewed
Jul 25, 2023
| @@ -109,7 +109,7 @@ You can replace the text within the `.navbar-brand` with an `<img>`. | |||
| <nav class="navbar bg-body-tertiary"> | |||
| <div class="container"> | |||
| <a class="navbar-brand" href="#"> | |||
| <img src="/docs/{{< param docs_version >}}/assets/brand/bootstrap-logo.svg" alt="Bootstrap" width="30" height="24"> | |||
| <img src="https://getbootstrap.com/docs/{{< param docs_version >}}/assets/brand/bootstrap-logo.svg" alt="Bootstrap" width="30" height="24"> | |||
There was a problem hiding this comment.
This kind of changes should be reverted. We need the files locally referenced.
|
Please split this kind of PRs into smaller ones. You have all kinds of different changes. I also left some comments from a very quick review. |
louismaximepiton
force-pushed
the
main-lmp-js-stackblitz
branch
from
9278923 to
625ca18
Compare
10 tasks
10 tasks
|
Most of the PR has been split. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First part is #39328. Rebase once merged.
Rewrite examples shortcodes. -> #39328.
Homogenize the examples over the doc. -> #39328.
Add some missing use cases in docsref page. -> #39328.
Change the CSS for example. -> #39328.
Some proposals to better the doc, meaning having some more Stackblitz examples.
Avoid having some dupe code to maintain
Introduce the use of
<skip>for example shortcode (not visible from anywhere for end-user). -> #39747.More details about the files changed
Changes that happen in the doc
New working StackBlitz example
Still some issues on them
Motivation & Context
Homogenize handling of our examples
Propose some missing examples to Stackblitz
Type of changes
Checklist
npm run lint)Live previews
Some examples of implementation
Check that the rendering of this page look good.
Related issues
Might close #36391.