Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: remove v4 reference on homepage #38946

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jul 21, 2023

Description

This PR removes the v4 reference on the homepage.

Before:
Screenshot 2023-07-21 at 08 49 54

In this PR:
Screenshot 2023-07-21 at 08 49 45

Motivation & Context

v4 is now deprecated/not supported so having it on the homepage IMO is a bit weird since it's not to be used anymore.

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review July 21, 2023 06:50
@XhmikosR XhmikosR requested a review from mdo July 23, 2023 19:15
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

@mdo mdo merged commit 4271d22 into main Jul 24, 2023
@mdo mdo deleted the main-jd-docs-drop-v4-reference-in-homepage branch July 24, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants