Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix radios looking like ellipse on responsive mode #38955

Merged
merged 6 commits into from
Sep 13, 2023

Conversation

SDClowen
Copy link
Contributor

@SDClowen SDClowen commented Jul 24, 2023

Description

Fixed bug the radios are seems to be like ellipse when use on responive mode

Motivation & Context

<label for="answer1" class="user-select-none p-4 list-group-item list-group-item-action border-0 border-bottom">
    <div class="d-flex">
        <input id="answer1" class="align-self-start form-check-input me-3" type="radio" name="answer" value="0">
        <h5 class="mb-1">Seçenek 1 - Mevcut Çalışma Saati Aralıkları Uygulaması</h5>
    </div>

Normal window size, The inputs are looks like....
image

Mobile Size, The inputs are seems like ellipsed
image

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

#radio

@SDClowen SDClowen requested a review from a team as a code owner July 24, 2023 06:19
@julien-deramond
Copy link
Member

Thanks for creating this PR @SDClowen
I'm not entirely sure for now that this fix is really needed as the semantics of your example seems to be distant from the semantics of the documentation (see https://getbootstrap.com/docs/5.3/components/list-group/#checkboxes-and-radios) where I don't seem to reproduce the issue.
Could you please try to create a minimal reproducible example with CodePen or any other tools?

@SDClowen
Copy link
Contributor Author

Ye you can see the problem on codepen
https://codepen.io/Mahmut-Yldrm-the-bold/pen/RwqYYww

@louismaximepiton
Copy link
Member

Isn't it a problem due to the use of flexboxes ? It seems that setting flex-shrink: 0; resolves the issue too.

@SDClowen
Copy link
Contributor Author

Isn't it a problem due to the use of flexboxes ? It seems that setting flex-shrink: 0; resolves the issue too.

Thanks for your suggestion. I changed it as you suggested.

https://codepen.io/SDClowen/pen/vYQQEbN

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this defensive CSS.

scss/forms/_form-check.scss Outdated Show resolved Hide resolved
@julien-deramond julien-deramond self-requested a review September 13, 2023 06:39
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defensive CSS approach LGTM!

@julien-deramond julien-deramond merged commit bb10c99 into twbs:main Sep 13, 2023
@XhmikosR XhmikosR changed the title Fixed bug the radios are seems to be like ellipse when use on respons… Fix radios looking like ellipse on responsive mode Sep 13, 2023
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Co-authored-by: louismaxime.piton <louismaxime.piton@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants