Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Please adjust default table-striped color when dark mode is active Fixes #39032

Closed
wants to merge 1 commit into from
Closed

fixed Please adjust default table-striped color when dark mode is active Fixes #39032

wants to merge 1 commit into from

Conversation

Mahendrareddy190
Copy link

Fixes #39029

Description

The comment suggests that there was a problem related to readability in the Dark mode of a table. In Dark mode, the background might have been too dark, making it difficult for users to distinguish the table text from the background. This lack of contrast can lead to an uncomfortable user experience and hinder accessibility.
so, I have added the table-dark to tables.

By incorporating the table-dark class, developers aim to enhance the user experience, especially when the application is being used in Dark mode. This change promotes accessibility and ensures that users can easily read and interact with the table's content, regardless of the chosen color scheme.

Before:
image
After:-
image

@Mahendrareddy190 Mahendrareddy190 changed the title fixed Please adjust default table-striped color when dark mode is active Fixes #39029 fixed Please adjust default table-striped color when dark mode is active Fixes Aug 10, 2023
@louismaximepiton
Copy link
Member

Hey,

Thanks a lot for your contribution. I think your solution, might introduce an issue for the doc in light mode. And it doesn't resolve the issue you mentionned since people still want to use standard tables.
Closing it for #39033. Feel free to debate if you think I've seen it wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please adjust default table-striped color when dark mode is active
2 participants