-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: stop running coveralls in forks #39096
Conversation
Not sure if this will work for PRs... It probably won't. My plan is to stop this from running when we are not on our repo or a PR against our repo. |
.github/workflows/js.yml
Outdated
@@ -46,6 +46,7 @@ jobs: | |||
|
|||
- name: Run Coveralls | |||
uses: coverallsapp/github-action@v2 | |||
if: github.repository == 'twbs/bootstrap' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe both are working but I've seen and used another approach to do that:
if: github.repository == 'twbs/bootstrap' | |
if: github.repository_owner == 'twbs' |
If I remember well, the job starts but is canceled because of the condition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could probably just use this too:
if: ${{ !github.event.repository.fork }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried it on a forked Bootstrap and it seems to work quite well. Didn't tried inside a PR against our repo.
No description provided.