-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Sass var $btn-link-focus-shadow-rgb
to allow customisation
#39119
New Sass var $btn-link-focus-shadow-rgb
to allow customisation
#39119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something has to be rethought in order not to increase the bundles size too much.
That's fair. I'm going to simply introduce a new Sass variable then, as you suggested: |
btn-link-focus-shadow-rgb
to allow customisation between color modes$btn-link-focus-shadow-rgb
to allow customisation
7ad8e47
to
4e41020
Compare
4e41020
to
7e10239
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
Description
Adds
$btn-link-focus-shadow-rgb
so that users can customise focus shadow for.btn-link
.Motivation & Context
Right now, for
.btn-link
, it's generated using only$link-color
.This might be undesirable and there should be an easy way to override it (e.g. users might want to change how it's calculated, or have specific design requirements that differ between light/dark theme).
Type of changes
Checklist
npm run lint
)Live previews